[docs] Fix parsing of x-date-pickers-pro demo adapter imports
#11628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LukasTy
added
bug 🐛
LukasTy
added
the
needs cherry-pick
LukasTy
commented
Jan 10, 2024
| @@ -18,7 +18,7 @@ export const ADAPTER_TO_LIBRARY: Record<string, string> = { | |||
| AdapterMomentJalaali: 'moment-jalaali', | |||
| }; | |||
|
|
|||
| const PICKERS_ADAPTER_REGEX = /^@mui\/(lab|x-date-pickers)\/(?<adapterName>Adapter.*)/; | |||
| const PICKERS_ADAPTER_REGEX = /^@mui\/(lab|x-date-pickers(?:-pro)?)\/(?<adapterName>Adapter.*)/; | |||
There was a problem hiding this comment.
We could go with the following if you think that it makes the code more readable. 🤔
Suggested change
| const PICKERS_ADAPTER_REGEX = /^@mui\/(lab|x-date-pickers(?:-pro)?)\/(?<adapterName>Adapter.*)/; | |
| const PICKERS_ADAPTER_REGEX = /^@mui\/(lab|x-date-pickers|x-date-pickers-pro)\/(?<adapterName>Adapter.*)/; |
There was a problem hiding this comment.
I'm honestly fine with both, it's not a regexp we need to tweak regularly
There was a problem hiding this comment.
Agree with @flaviendelangle ... both are fine
|
Deploy preview: https://deploy-preview-11628--material-ui-x.netlify.app/ |
flaviendelangle
approved these changes
Jan 10, 2024
michelengelen
approved these changes
Jan 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed that after #11463 and specifically https://github.com/mui/mui-x/pull/11463/files#diff-41c21e2dc42b8c223fc2fa17580e58041afa590fe34d9fbe9a1ffbe5e17d318bL46 our demos using
@mui/x-date-pickers-pro/<adapterName>import no longer work, because the regex doesn't account for the possibility of the adapter being imported from the pro package.